Messages in this thread | | | Date | Tue, 4 Jan 2022 18:54:37 -0800 | Subject | Re: [PATCH -next v2] notifier: Fix some kernel-doc comments | From | Randy Dunlap <> |
| |
On 1/4/22 18:52, Yang Li wrote: > Remove some warnings found by running scripts/kernel-doc, > which is caused by using 'make W=1'. > kernel/notifier.c:68: warning: Excess function parameter 'returns' > description in 'notifier_call_chain' > kernel/notifier.c:116: warning: Function parameter or member 'v' not > described in 'notifier_call_chain_robust' > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> --- > kernel/notifier.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/kernel/notifier.c b/kernel/notifier.c > index ba005ebf4730..0e3fef8ff816 100644 > --- a/kernel/notifier.c > +++ b/kernel/notifier.c > @@ -59,8 +59,7 @@ static int notifier_chain_unregister(struct notifier_block **nl, > * value of this parameter is -1. > * @nr_calls: Records the number of notifications sent. Don't care > * value of this field is NULL. > - * @returns: notifier_call_chain returns the value returned by the > - * last notifier function called. > + * Return: the value returned by the last notifier function called. > */ > static int notifier_call_chain(struct notifier_block **nl, > unsigned long val, void *v, > @@ -102,7 +101,7 @@ NOKPROBE_SYMBOL(notifier_call_chain); > * @val_up: Value passed unmodified to the notifier function > * @val_down: Value passed unmodified to the notifier function when recovering > * from an error on @val_up > - * @v Pointer passed unmodified to the notifier function > + * @v: Pointer passed unmodified to the notifier function > * > * NOTE: It is important the @nl chain doesn't change between the two > * invocations of notifier_call_chain() such that we visit the
-- ~Randy
| |