lkml.org 
[lkml]   [2022]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] headers/uninline: Uninline single-use function: kobject_has_children()

    * Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

    > On Tue, Jan 04, 2022 at 04:09:57PM +0100, Greg Kroah-Hartman wrote:
    > > On Tue, Jan 04, 2022 at 02:54:31PM +0100, Ingo Molnar wrote:
    > > >
    > > > * Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
    > > >
    > > > > On Tue, Jan 04, 2022 at 11:54:55AM +0100, Ingo Molnar wrote:
    > > > > > There's one happy exception though, all the uninlining patches that
    > > > > > uninline a single-call function are probably fine as-is:
    > > > >
    > > > > <snip>
    > > > >
    > > > > > 3443e75fd1f8 headers/uninline: Uninline single-use function: kobject_has_children()
    > > > >
    > > > > Let me go take this right now, no need for this to wait, it should be
    > > > > out of kobject.h as you rightfully show there is only one user.
    > > >
    > > > Sure - here you go!
    > >
    > > I just picked it out of your git tree already :)
    > >
    > > Along those lines, any objection to me taking at least one other one?
    > > 3f8757078d27 ("headers/prep: usb: gadget: Fix namespace collision") and

    Ack.

    > > 6fb993fa3832 ("headers/deps: USB: Optimize <linux/usb/ch9.h>

    Ack.

    > > dependencies, remove <linux/device.h>") look like I can take now into my
    > > USB tree with no problems.
    >
    > Also these look good to go now:
    > bae9ddd98195 ("headers/prep: Fix non-standard header section: drivers/usb/cdns3/core.h")

    Ack.

    > c027175b37e5 ("headers/prep: Fix non-standard header section: drivers/usb/host/ohci-tmio.c")

    Ack.

    Note that these latter two patches just simplified the task of my
    (simplistic) tooling, which is basically a shell script that inserts
    header dependencies to the head of .c and .h files, right in front of
    the first #include line it encounters.

    These two patches do have some marginal clean-up value too, so I'm not
    opposed to merging them - just wanted to declare their true role. :-)

    Thanks,

    Ingo

    \
     
     \ /
      Last update: 2022-01-05 01:11    [W:4.170 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site