lkml.org 
[lkml]   [2022]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3/4] Documentation:ABI:testing:admv1014: add ABI docs
On Thu, 27 Jan 2022 12:55:57 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Add documentation for the use of the Digital Attenuator gain.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v4:
> - move `in_altvoltage_calibscale` to sysfs-bus-iio
> Documentation/ABI/testing/sysfs-bus-iio | 7 ++++++
> .../testing/sysfs-bus-iio-frequency-admv1014 | 23 +++++++++++++++++++
> 2 files changed, 30 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index c551301b33f1..d7d96d3d6b7c 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -476,6 +476,13 @@ What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_i_calibscale
> What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_q_calibscale
> What: /sys/bus/iio/devices/iio:deviceX/in_voltage_i_calibscale
> What: /sys/bus/iio/devices/iio:deviceX/in_voltage_q_calibscale
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage_calibscale
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Used in microwave converters to read/write value for the
> + digital attenuator gain (I/Q mode).
> +

You can't add description etc in the middle of a load of What: entries like this.
Just add the What line. The generic description text should be sufficient.

> What: /sys/bus/iio/devices/iio:deviceX/in_voltage_calibscale
> What: /sys/bus/iio/devices/iio:deviceX/in_accel_x_calibscale
> What: /sys/bus/iio/devices/iio:deviceX/in_accel_y_calibscale
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014 b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> new file mode 100644
> index 000000000000..5bcd96d77f45
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> @@ -0,0 +1,23 @@
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_coarse
> +KernelVersion:

Fill these in. If something odd happens to delay it getting merged I can fix them up, but
I may well forget to fill them in if left empty. Basically make life easy for me in the
common case. This 'should' be 5.18 material.

> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_coarse
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with fine steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with fine steps.

\
 
 \ /
  Last update: 2022-01-30 13:04    [W:0.046 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site