Messages in this thread | | | From | Martin Fernandez <> | Date | Wed, 26 Jan 2022 11:03:50 -0300 | Subject | Re: [PATCH v5 3/5] x86/e820: Tag e820_entry with crypto capabilities |
| |
> On 1/14/22, Dave Hansen <dave.hansen@intel.com> wrote: >> On 1/13/22 1:30 PM, Martin Fernandez wrote: >>> +/* >>> + * Update crypto capabilities in a range >>> + */ >>> +static u64 __init __e820__range_update_crypto(struct e820_table *table, >>> + u64 start, u64 size, >>> + enum e820_crypto_capabilities crypto_capable) >> >> This looks like an almost pure copy-and-paste of a 70-line function. >> That's not the end of the world, but it does seem like a place where >> refactoring is in order.
Introducing a for_each to iterate over the table is one of the improvements I'm thinking of. Do you think it's a good idea to introduce it in this patch (changing all the relevant for loops for this new for_each) or should I do it in a separate patch?
| |