Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH v2 4/7] usb: dwc3: Program GFLADJ | Date | Wed, 26 Jan 2022 12:53:28 +0200 |
| |
Hi,
Sean Anderson <sean.anderson@seco.com> writes:
> On 1/24/22 9:11 PM, Thinh Nguyen wrote: >>>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >>>>> index 5214daceda86..883e119377f0 100644 >>>>> --- a/drivers/usb/dwc3/core.c >>>>> +++ b/drivers/usb/dwc3/core.c >>>>> @@ -348,7 +348,7 @@ static void dwc3_frame_length_adjustment(struct dwc3 *dwc) >>>>> static void dwc3_ref_clk_period(struct dwc3 *dwc) >>>>> { >>>>> u32 reg; >>>>> - unsigned long rate, period; >>>>> + unsigned long decr, fladj, rate, period; >>>> >>>> Minor style nit: Felipe prefers to keep the declaration on separate >>>> lines, let's keep it consistent with the rest in this driver. >>> >>> So >>> >>> unsigned int decr; >>> unsigned int fladj; >>> unsigned int rate; >>> unsigned int period; >>> >>> ? >>> >>> Frankly that seems rather verbose. >> >> A couple of the benefits of having it like this is to help with viewing >> git-blame if we introduce new variables and help with backporting fix >> patch a bit simpler. Mainly I'm just following Felipe's style and keep >> it consistent in this driver, but I don't think it's a big deal. > > *shrug* > > If it's the subsystem style I will rewrite it. > > (btw is this documented anywhere for future contributors?)
https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
"To this end, use just one data declaration per line (no commas for multiple data declarations)"
-- balbi
| |