lkml.org 
[lkml]   [2022]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 08/31] clk: mediatek: cpumux: Clean up included headers
    Date
    > Some headers with the declaration of functions and structures aren't
    > directly included. Explicitly include them so that future changes to
    > other headers would not result in an unexpected build break.
    >
    > On the header side, add forward declarations for any data structures
    > whose pointers are used in function signatures. No headers are
    > required.
    >
    > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

    Reviewed-by: Miles Chen <miles.chen@mediatek.com>

    > ---
    > drivers/clk/mediatek/clk-cpumux.c | 3 +++
    > drivers/clk/mediatek/clk-cpumux.h | 4 ++++
    > 2 files changed, 7 insertions(+)
    >
    > diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c
    > index 344c6399b22f..658aee789f44 100644
    > --- a/drivers/clk/mediatek/clk-cpumux.c
    > +++ b/drivers/clk/mediatek/clk-cpumux.c
    > @@ -5,8 +5,11 @@
    > */
    >
    > #include <linux/clk-provider.h>
    > +#include <linux/container_of.h>
    > +#include <linux/err.h>
    > #include <linux/mfd/syscon.h>
    > #include <linux/module.h>
    > +#include <linux/regmap.h>
    > #include <linux/slab.h>
    >
    > #include "clk-mtk.h"
    > diff --git a/drivers/clk/mediatek/clk-cpumux.h b/drivers/clk/mediatek/clk-cpumux.h
    > index a538f2bbef0d..b07e89f7c283 100644
    > --- a/drivers/clk/mediatek/clk-cpumux.h
    > +++ b/drivers/clk/mediatek/clk-cpumux.h
    > @@ -7,6 +7,10 @@
    > #ifndef __DRV_CLK_CPUMUX_H
    > #define __DRV_CLK_CPUMUX_H
    >
    > +struct clk_onecell_data;
    > +struct device_node;
    > +struct mtk_composite;
    > +
    > int mtk_clk_register_cpumuxes(struct device_node *node,
    > const struct mtk_composite *clks, int num,
    > struct clk_onecell_data *clk_data);
    > --
    > 2.35.0.rc0.227.g00780c9af4-goog


    \
     
     \ /
      Last update: 2022-01-25 18:28    [W:3.901 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site