lkml.org 
[lkml]   [2022]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 24/54] time: replace cpumask_weight with cpumask_empty in clocksource.c
    Date
    clocksource_verify_percpu() calls cpumask_weight() to check if any bit of
    a given cpumask is set. We can do it more efficiently with cpumask_empty()
    because cpumask_empty() stops traversing the cpumask as soon as it finds
    first set bit, while cpumask_weight() counts all bits unconditionally.

    Signed-off-by: Yury Norov <yury.norov@gmail.com>
    ---
    kernel/time/clocksource.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
    index 1cf73807b450..a2fecb4d8c0e 100644
    --- a/kernel/time/clocksource.c
    +++ b/kernel/time/clocksource.c
    @@ -337,7 +337,7 @@ void clocksource_verify_percpu(struct clocksource *cs)
    cpus_read_lock();
    preempt_disable();
    clocksource_verify_choose_cpus();
    - if (cpumask_weight(&cpus_chosen) == 0) {
    + if (cpumask_empty(&cpus_chosen)) {
    preempt_enable();
    cpus_read_unlock();
    pr_warn("Not enough CPUs to check clocksource '%s'.\n", cs->name);
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-01-23 19:42    [W:4.146 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site