lkml.org 
[lkml]   [2022]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 27/31] clk: mediatek: Unregister clks in mtk_clk_simple_probe() error path
    Date
    Until now the mediatek clk driver library did not have any way to
    unregister clks, and so all drivers did not do proper cleanup in
    their error paths.

    Now that the library does have APIs to unregister clks, use them
    in the error path of mtk_clk_simple_probe() to do proper cleanup.

    Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
    ---
    drivers/clk/mediatek/clk-mtk.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c
    index e1977c8e130a..6d0b8842971b 100644
    --- a/drivers/clk/mediatek/clk-mtk.c
    +++ b/drivers/clk/mediatek/clk-mtk.c
    @@ -434,12 +434,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev)

    r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
    if (r)
    - goto free_data;
    + goto unregister_clks;

    platform_set_drvdata(pdev, clk_data);

    return r;

    +unregister_clks:
    + mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data);
    free_data:
    mtk_free_clk_data(clk_data);
    return r;
    --
    2.35.0.rc0.227.g00780c9af4-goog
    \
     
     \ /
      Last update: 2022-01-22 10:21    [W:3.112 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site