Messages in this thread | | | Date | Sat, 22 Jan 2022 17:22:22 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 0/3] perf: Support event alias in form foo-bar-baz |
| |
Em Mon, Jan 17, 2022 at 08:21:42AM -0800, Ian Rogers escreveu: > On Mon, Jan 17, 2022 at 7:15 AM John Garry <john.garry@huawei.com> wrote: > > > > Currently event aliases in the form foo-bar-baz are not supported. > > > > The HiSilicon D06 platform has uncore event aliases in that form, and > > using those aliases fail: > > > > $ ./perf list sdir-home-migrate > > > > List of pre-defined events (to be used in -e): > > > > uncore hha: > > sdir-home-migrate > > [Unit: hisi_sccl,hha] > > > > $ sudo ./perf stat -e sdir-home-migrate > > event syntax error: 'sdir-home-migrate' > > \___ parser error > > Run 'perf list' for a list of valid events > > > > Usage: perf stat [<options>] [<command>] > > > > -e, --event <event>event selector. use 'perf list' to list available events > > > > This series added support for such an event alias form. > > > > I am no expert on l+y, so any and all review here would be appreciated, > > especially the last patch which is marked as RFC (for that same reason). > > > > The series is based on acme perf/core @ 9bce13ea88f8. > > > > John Garry (3): > > perf parse-events: Support event alias in form foo-bar-baz > > perf test: Add pmu-events test for aliases with hyphens > > perf test: Add parse-events test for aliases with hyphens > > The whole set: > > Acked-by: Ian Rogers <irogers@google.com> > > The additional code is no worse than the existing code. The testing is > a great addition!
Indeed, thanks a lot!
Thanks, applied.
- Arnaldo
> Thanks, > Ian > > > .../arch/test/test_soc/cpu/uncore.json | 16 +++++ > > tools/perf/tests/parse-events.c | 49 ++++++++++++++ > > tools/perf/tests/pmu-events.c | 32 +++++++++ > > tools/perf/util/parse-events.c | 67 ++++++++++++++++--- > > tools/perf/util/parse-events.h | 1 + > > tools/perf/util/parse-events.l | 2 + > > tools/perf/util/parse-events.y | 17 ++++- > > 7 files changed, 171 insertions(+), 13 deletions(-) > > > > -- > > 2.26.2 > >
--
- Arnaldo
| |