lkml.org 
[lkml]   [2022]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 26/35] brcmfmac: cfg80211: Pass the PMK in binary instead of hex
    On 1/4/2022 8:26 AM, Hector Martin wrote:
    > Apparently the hex passphrase mechanism does not work on newer
    > chips/firmware (e.g. BCM4387). It seems there was a simple way of
    > passing it in binary all along, so use that and avoid the hexification.
    >
    > OpenBSD has been doing it like this from the beginning, so this should
    > work on all chips.
    >
    > Also clear the structure before setting the PMK. This was leaking
    > uninitialized stack contents to the device.
    >
    > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
    > Signed-off-by: Hector Martin <marcan@marcan.st>
    > ---
    > .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 13 +++++++------
    > 1 file changed, 7 insertions(+), 6 deletions(-)
    [unhandled content-type:application/pkcs7-signature]
    \
     
     \ /
      Last update: 2022-01-21 08:36    [W:6.509 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site