lkml.org 
[lkml]   [2022]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5] dma-buf: system_heap: Add a size check for allocation
    Date
    From: Guangming <Guangming.Cao@mediatek.com>

    Add a size check for allocation since the allocation size should be
    always less than the total DRAM size on system heap.
    Adding this check can prevent comsuming too much time for invalid allocations.

    Signed-off-by: Guangming <Guangming.Cao@mediatek.com>
    ---
    drivers/dma-buf/heaps/system_heap.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c
    index 23a7e74ef966..459dc18bc4a2 100644
    --- a/drivers/dma-buf/heaps/system_heap.c
    +++ b/drivers/dma-buf/heaps/system_heap.c
    @@ -347,6 +347,14 @@ static struct dma_buf *system_heap_allocate(struct dma_heap *heap,
    struct page *page, *tmp_page;
    int i, ret = -ENOMEM;

    + /*
    + * Size check. The "len" should be less than totalram since system_heap
    + * memory is comes from system. Adding check here can prevent comsuming
    + * too much time for invalid allocations.
    + */
    + if (len >> PAGE_SHIFT > totalram_pages())
    + return ERR_PTR(-EINVAL);
    +
    buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
    if (!buffer)
    return ERR_PTR(-ENOMEM);
    --
    2.17.1
    \
     
     \ /
      Last update: 2022-01-20 08:09    [W:3.387 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site