lkml.org 
[lkml]   [2022]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: fix typos of "its" and "reponse"
On Sat, Dec 25, 2021 at 06:52:15PM -0800, Randy Dunlap wrote:
> Use the possessive "its" instead of the contraction of "it is" ("it's")
> where needed in user-viewable messages.

> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> @@ -184,8 +184,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",

You should probably s/till/until/, since you're already modifying those lines.
Is there a reason that "Coherent" is capitalized here?

> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> @@ -304,8 +304,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",

same

PC

\
 
 \ /
  Last update: 2022-01-02 23:51    [W:0.112 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site