lkml.org 
[lkml]   [2022]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used
Thus wrote Michael Straube (straube.linux@gmail.com):

> The field UsbRxHighSpeedMode of struct hal_data_8188e is set but
> never used. Remove it.

> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> v3: no changes
> v2: no changes

> drivers/staging/r8188eu/hal/usb_halinit.c | 5 -----
> drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 ---
> 2 files changed, 8 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index 104705ef170e..96db9a8e7667 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -502,16 +502,11 @@ usb_AggSettingRxUpdate(

> static void InitUsbAggregationSetting(struct adapter *Adapter)
> {
> - struct hal_data_8188e *haldata = &Adapter->haldata;
> -
> /* Tx aggregation setting */
> usb_AggSettingTxUpdate(Adapter);

> /* Rx aggregation setting */
> usb_AggSettingRxUpdate(Adapter);
> -
> - /* 201/12/10 MH Add for USB agg mode dynamic switch. */
> - haldata->UsbRxHighSpeedMode = false;
> }

> static void _InitOperationMode(struct adapter *Adapter)
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index e8cb093abb62..8b54f52f49e2 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -262,9 +262,6 @@ struct hal_data_8188e {
> u8 OutEpQueueSel;
> u8 OutEpNumber;

> - /* Add for USB aggreation mode dynamic shceme. */
> - bool UsbRxHighSpeedMode;
> -
> /* 2010/11/22 MH Add for slim combo debug mode selective. */
> /* This is used for fix the drawback of CU TSMC-A/UMC-A cut.
> * HW auto suspend ability. Close BT clock. */
> --
> 2.34.1

Acked-by: Martin Kaiser <martin@kaiser.cx>

\
 
 \ /
  Last update: 2022-01-02 18:07    [W:0.056 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site