| Date | Mon, 17 Jan 2022 08:57:48 +0100 | Subject | Re: [PATCH v2 04/30] s390/sclp: detect the AISI facility | From | Thomas Huth <> |
| |
On 14/01/2022 21.31, Matthew Rosato wrote: > Detect the Adapter Interruption Suppression Interpretation facility. > > Reviewed-by: Eric Farman <farman@linux.ibm.com> > Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com> > Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com> > --- > arch/s390/include/asm/sclp.h | 1 + > drivers/s390/char/sclp_early.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/s390/include/asm/sclp.h b/arch/s390/include/asm/sclp.h > index 8c2e142000d4..33b174007848 100644 > --- a/arch/s390/include/asm/sclp.h > +++ b/arch/s390/include/asm/sclp.h > @@ -91,6 +91,7 @@ struct sclp_info { > unsigned char has_zpci_lsi : 1; > unsigned char has_aisii : 1; > unsigned char has_aeni : 1; > + unsigned char has_aisi : 1; > unsigned int ibc; > unsigned int mtid; > unsigned int mtid_cp; > diff --git a/drivers/s390/char/sclp_early.c b/drivers/s390/char/sclp_early.c > index e9af01b4c97a..c13e55cc4a5d 100644 > --- a/drivers/s390/char/sclp_early.c > +++ b/drivers/s390/char/sclp_early.c > @@ -47,6 +47,7 @@ static void __init sclp_early_facilities_detect(void) > sclp.has_kss = !!(sccb->fac98 & 0x01); > sclp.has_aisii = !!(sccb->fac118 & 0x40); > sclp.has_aeni = !!(sccb->fac118 & 0x20); > + sclp.has_aisi = !!(sccb->fac118 & 0x10); > sclp.has_zpci_lsi = !!(sccb->fac118 & 0x01); > if (sccb->fac85 & 0x02) > S390_lowcore.machine_flags |= MACHINE_FLAG_ESOP;
Just a matter of taste, but I'd maybe squash patches 1 - 4 into one patch.
Thomas
|