lkml.org 
[lkml]   [2022]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] scsi: 3w-sas: Remove useless DMA-32 fallback configuration
    Date
    As stated in [1], dma_set_mask() with a 64-bit mask never fails if
    dev->dma_mask is non-NULL.
    So, if it fails, the 32 bits case will also fail for the same reason.

    Simplify code and remove some dead code accordingly.

    [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    ---
    drivers/scsi/3w-sas.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c
    index b9482da79512..3ebe66151dcb 100644
    --- a/drivers/scsi/3w-sas.c
    +++ b/drivers/scsi/3w-sas.c
    @@ -1567,8 +1567,6 @@ static int twl_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id)
    pci_try_set_mwi(pdev);

    retval = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
    - if (retval)
    - retval = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
    if (retval) {
    TW_PRINTK(host, TW_DRIVER, 0x18, "Failed to set dma mask");
    retval = -ENODEV;
    @@ -1786,8 +1784,6 @@ static int __maybe_unused twl_resume(struct device *dev)
    pci_try_set_mwi(pdev);

    retval = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
    - if (retval)
    - retval = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
    if (retval) {
    TW_PRINTK(host, TW_DRIVER, 0x25, "Failed to set dma mask during resume");
    retval = -ENODEV;
    --
    2.32.0
    \
     
     \ /
      Last update: 2022-01-15 09:54    [W:3.481 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site