Messages in this thread | | | Date | Sat, 15 Jan 2022 20:47:38 +0100 | Subject | Re: [PATCH v8 4/4] m68k: introduce a virtual m68k machine | From | Laurent Vivier <> |
| |
Le 15/01/2022 à 20:41, Geert Uytterhoeven a écrit : > Hi Laurent, > > On Sat, Jan 15, 2022 at 8:33 PM Laurent Vivier <laurent@vivier.eu> wrote: >> This machine allows to have up to 3.2 GiB and 128 Virtio devices. >> >> It is based on android goldfish devices. >> >> Signed-off-by: Laurent Vivier <laurent@vivier.eu> > > Thanks for your patch (the new versions keep on coming quickly). > >> --- /dev/null >> +++ b/arch/m68k/virt/platform.c > >> +static int __init virt_platform_init(void) >> +{ >> + const struct resource goldfish_tty_res[] = { >> + DEFINE_RES_MEM(virt_bi_data.tty.mmio, 1), >> + DEFINE_RES_IRQ(virt_bi_data.tty.irq), >> + }; >> + /* this is the second gf-rtc, the first one is used by the scheduler */ >> + const struct resource goldfish_rtc_res[] = { >> + DEFINE_RES_MEM(virt_bi_data.rtc.mmio + 0x1000, 0x1000), >> + DEFINE_RES_IRQ(virt_bi_data.rtc.irq + 1), >> + }; >> + extern unsigned long min_low_pfn; > > checkpatch keeps on complaining. > #include <linux/memblock.h> instead?
oh, yes, I didn't see it was defined here. Thank you.
I've updated my patch, the change will be in the next version.
Thanks, Laurent
| |