lkml.org 
[lkml]   [2022]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] ALSA: hda: cs35l41: Tidyup code and add default cases
On Thu, 13 Jan 2022 18:07:27 +0100,
Lucas Tanure wrote:
>
> Clean up the code, plus adding default cases for switch
> and dev_err_probe use.

Please split to patches. There are too much mixed up of changes for
different goals. There is difference between a white-space cleanup or
such (that is, no significant change of the resultant binary), a
cleanup with a better API usage, and a code refactoring. And, the
addition of the missing default case is rather the fix, not a clean
up...


thanks,

Takashi

\
 
 \ /
  Last update: 2022-01-14 17:16    [W:0.084 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site