Messages in this thread | | | Date | Fri, 14 Jan 2022 17:15:31 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH 4/5] ALSA: hda: cs35l41: Tidyup code and add default cases |
| |
On Thu, 13 Jan 2022 18:07:27 +0100, Lucas Tanure wrote: > > Clean up the code, plus adding default cases for switch > and dev_err_probe use.
Please split to patches. There are too much mixed up of changes for different goals. There is difference between a white-space cleanup or such (that is, no significant change of the resultant binary), a cleanup with a better API usage, and a code refactoring. And, the addition of the missing default case is rather the fix, not a clean up...
thanks,
Takashi
| |