Messages in this thread | | | From | "G, GurucharanX" <> | Subject | RE: [Intel-wired-lan] [PATCH] i40e: Remove useless DMA-32 fallback configuration | Date | Thu, 13 Jan 2022 18:33:36 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Christophe JAILLET > Sent: Sunday, January 9, 2022 10:45 PM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; > Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; linux- > kernel@vger.kernel.org; Christophe JAILLET > <christophe.jaillet@wanadoo.fr>; intel-wired-lan@lists.osuosl.org; Christoph > Hellwig <hch@lst.de> > Subject: [Intel-wired-lan] [PATCH] i40e: Remove useless DMA-32 fallback > configuration > > As stated in [1], dma_set_mask() with a 64-bit mask never fails if > dev->dma_mask is non-NULL. > So, if it fails, the 32 bits case will also fail for the same reason. > > So, if dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to > be 1. > > Simplify code and remove some dead code accordingly. > > [1]: https://lkml.org/lkml/2021/6/7/398 > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com> > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) >
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
| |