Messages in this thread | | | Date | Thu, 13 Jan 2022 18:03:07 +0100 | Subject | Re: [for-next][PATCH 05/31] tracing: Have existing event_command.parse() implementations use helpers | From | Daniel Bristot de Oliveira <> |
| |
Hi
On 1/11/22 18:30, Steven Rostedt wrote: > From: Tom Zanussi <zanussi@kernel.org> > > Simplify the existing event_command.parse() implementations by having > them make use of the helper functions previously introduced.
While testing rtla with all for-next changes, I noticed this patch breaks:
# rtla osnoise hist -d 5
Before this patch, osnoise hist is able to enable histograms and collect data. After this patch it does not work.
The event I am creating the histogram is osnoise:sample_threshold, and the trigger command is:
hist:keys=duration.buckets=1000,common_cpu:vals=hitcount:sort=hitcount:size=2048
I did some debug, and found that the histogram is working. The problem is that, to read the histogram I pause it to have consistent data:
in tools/tracing/rtla/osnoise_hist.c: osnoise_read_trace_hist() { [...] tracefs_hist_pause(tool->trace.inst, data->trace_hist);
content = tracefs_event_file_read(tool->trace.inst, "osnoise", "sample_threshold", "hist", NULL); [...] }
and, as far as I got, after this patch, pausing the histogram makes it to clear up. If I comment the "tracefs_hist_pause" line, "rtla osnoise hist" start working back again.
Thoughts?
-- Daniel
| |