Messages in this thread | | | Date | Wed, 12 Jan 2022 10:42:22 -1000 | From | Tejun Heo <> | Subject | Re: [PATCH v2 3/3] sched/core: Force idle accounting per cgroup |
| |
Hello,
On Tue, Jan 11, 2022 at 05:56:01PM +0800, Cruz Zhao wrote: > +#ifdef CONFIG_SCHED_CORE > +void cpuacct_account_forceidle(int cpu, struct task_struct *tsk, u64 cputime) > +{ > + struct cpuacct *ca; > + u64 *fi; > + > + rcu_read_lock(); > + /* > + * We have hold rq->core->__lock here, which protects ca->forceidle > + * percpu. > + */ > + for (ca = task_ca(tsk); ca; ca = parent_ca(ca)) { > + fi = per_cpu_ptr(ca->forceidle, cpu); > + *fi += cputime; > + }
Please don't do this. Use rstat and integrate it with other stats.
Thanks.
-- tejun
| |