Messages in this thread | | | Subject | Re: [PATCH v2 0/1] firmware: mtk: add adsp ipc protocol for sof | From | Pierre-Louis Bossart <> | Date | Wed, 12 Jan 2022 10:42:04 -0600 |
| |
On 1/12/22 5:32 AM, allen-kh.cheng wrote: > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > This patch provides mtk adsp ipc support for sof. > > ADSP IPC protocol offers (send/recv) interfaces using > mediatek-mailbox APIs. > > changes since v1: > - add comments for mtk_adsp_ipc_send and mtk_adsp_ipc_recv > - remove unuseful MODULE_LICENSE > - change label name to out_free
my comment was not on changing the label name, but making sure you only free something that was allocated by using *two* labels.
> > Allen-KH Cheng (1): > firmware: mediatek: add adsp ipc protocol interface > > drivers/firmware/Kconfig | 1 + > drivers/firmware/Makefile | 1 + > drivers/firmware/mediatek/Kconfig | 9 + > drivers/firmware/mediatek/Makefile | 2 + > drivers/firmware/mediatek/mtk-adsp-ipc.c | 159 ++++++++++++++++++ > .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ > 6 files changed, 237 insertions(+) > create mode 100644 drivers/firmware/mediatek/Kconfig > create mode 100644 drivers/firmware/mediatek/Makefile > create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c > create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h >
| |