lkml.org 
[lkml]   [2022]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] arm64: dts: meson-g12-common: add uart_ao_b pins muxing
From
Date
Hi,

On 03/01/2022 16:46, Gary Bisson wrote:
> - RX/TX signals can be mapped on 2 different pairs of pins so supporting
> both options
> - RTS/CTS signals however only have 1 option available
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> .../boot/dts/amlogic/meson-g12-common.dtsi | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index af1357c48bee..3a7773ffbd08 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1952,6 +1952,33 @@ mux {
> };
> };
>
> + uart_ao_b_1_pins: uart-ao-b-1 {
> + mux {
> + groups = "uart_ao_b_tx_2",
> + "uart_ao_b_rx_3";
> + function = "uart_ao_b";
> + bias-disable;
> + };
> + };
> +
> + uart_ao_b_2_pins: uart-ao-b-2 {
> + mux {
> + groups = "uart_ao_b_tx_8",
> + "uart_ao_b_rx_9";
> + function = "uart_ao_b";
> + bias-disable;
> + };
> + };

I'm not fan of these nodes namings.

Perhaps :
- uart-ao-b-2-3
- uart-ao-b-8-9

so the actual pins numbers used are more clear ?

> +
> + uart_ao_b_cts_rts_pins: uart-ao-b-cts-rts {
> + mux {
> + groups = "uart_ao_b_cts",
> + "uart_ao_b_rts";
> + function = "uart_ao_b";
> + bias-disable;
> + };
> + };
> +
> pwm_a_e_pins: pwm-a-e {
> mux {
> groups = "pwm_a_e";
>

\
 
 \ /
  Last update: 2022-01-12 09:34    [W:1.389 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site