lkml.org 
[lkml]   [2022]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 22/28] gup: Convert gup_huge_pmd() to use a folio
    From
    On 1/9/22 20:24, Matthew Wilcox (Oracle) wrote:
    > Use the new folio-based APIs.
    >
    > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    > ---
    > mm/gup.c | 11 ++++++-----
    > 1 file changed, 6 insertions(+), 5 deletions(-)
    >

    Reviewed-by: John Hubbard <jhubbard@nvidia.com>


    thanks,
    --
    John Hubbard
    NVIDIA

    > diff --git a/mm/gup.c b/mm/gup.c
    > index 250326458df6..a006bce2d47b 100644
    > --- a/mm/gup.c
    > +++ b/mm/gup.c
    > @@ -2492,7 +2492,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long addr,
    > unsigned long end, unsigned int flags,
    > struct page **pages, int *nr)
    > {
    > - struct page *head, *page;
    > + struct page *page;
    > + struct folio *folio;
    > int refs;
    >
    > if (!pmd_access_permitted(orig, flags & FOLL_WRITE))
    > @@ -2508,17 +2509,17 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long addr,
    > page = nth_page(pmd_page(orig), (addr & ~PMD_MASK) >> PAGE_SHIFT);
    > refs = record_subpages(page, addr, end, pages + *nr);
    >
    > - head = try_grab_compound_head(pmd_page(orig), refs, flags);
    > - if (!head)
    > + folio = try_grab_folio(page, refs, flags);
    > + if (!folio)
    > return 0;
    >
    > if (unlikely(pmd_val(orig) != pmd_val(*pmdp))) {
    > - put_compound_head(head, refs, flags);
    > + gup_put_folio(folio, refs, flags);
    > return 0;
    > }
    >
    > *nr += refs;
    > - SetPageReferenced(head);
    > + folio_set_referenced(folio);
    > return 1;
    > }
    >

    \
     
     \ /
      Last update: 2022-01-11 08:36    [W:4.081 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site