Messages in this thread | | | From | Lukasz Stelmach <> | Subject | Re: [PATCH v2 11/13] media: s5p-g2d: Use platform_get_irq() to get the interrupt | Date | Tue, 11 Jan 2022 15:49:06 +0100 |
| |
It was <2022-01-11 wto 00:23>, when Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq(). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v1->v2 > * No change. > --- > drivers/media/platform/s5p-g2d/g2d.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) >
Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
> diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c > index fa0bb31bd2b9..dd8864779a7c 100644 > --- a/drivers/media/platform/s5p-g2d/g2d.c > +++ b/drivers/media/platform/s5p-g2d/g2d.c > @@ -623,7 +623,6 @@ static int g2d_probe(struct platform_device *pdev) > { > struct g2d_dev *dev; > struct video_device *vfd; > - struct resource *res; > const struct of_device_id *of_id; > int ret = 0; > > @@ -664,14 +663,11 @@ static int g2d_probe(struct platform_device *pdev) > goto put_clk_gate; > } > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (!res) { > - dev_err(&pdev->dev, "failed to find IRQ\n"); > - ret = -ENXIO; > + ret = platform_get_irq(pdev, 0); > + if (ret < 0) > goto unprep_clk_gate; > - } > > - dev->irq = res->start; > + dev->irq = ret; > > ret = devm_request_irq(&pdev->dev, dev->irq, g2d_isr, > 0, pdev->name, dev);
-- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics [unhandled content-type:application/pgp-signature] | |