lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drivers/soundwire: remove redundant val variable
From
On 2022-01-10 11:47 AM, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from SWRM_REG_VAL_PACK() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
> drivers/soundwire/qcom.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 54813417ef8e..77f9c90370be 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -235,7 +235,6 @@ static int qcom_swrm_cpu_reg_write(struct qcom_swrm_ctrl *ctrl, int reg,
> static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data,
> u8 dev_addr, u16 reg_addr)
> {
> - u32 val;
> u8 id = *cmd_id;
>
> if (id != SWR_BROADCAST_CMD_ID) {
> @@ -245,9 +244,8 @@ static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data,
> id = 0;
> *cmd_id = id;
> }
> - val = SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr);
>
> - return val;
> + return SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr);
> }
>
> static int swrm_wait_for_rd_fifo_avail(struct qcom_swrm_ctrl *swrm)
>

Hello,

While the change looks good, the subject (commit title) seems off.
Please take a look at commit titles found in drivers/soundwire, you'll
find several good candidates there.


Regards,
Czarek

\
 
 \ /
  Last update: 2022-01-10 17:33    [W:0.532 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site