lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectdrivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Hi Zhenyu,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: df0cc57e057f18e44dac8e6c18aba47ab53202f9
commit: 145e06b58f8625becc61792a0554726314297a85 drm/i915/gvt: Move mdev attribute groups into kvmgt module
date: 8 months ago
config: x86_64-randconfig-a016-20210927 (https://download.01.org/0day-ci/archive/20220110/202201102031.xPWND4ZH-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=145e06b58f8625becc61792a0554726314297a85
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 145e06b58f8625becc61792a0554726314297a85
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Check if can do 2M page
drivers/gpu/drm/i915/gvt/gtt.c:2209: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead


vim +1152 drivers/gpu/drm/i915/gvt/gtt.c

2707e44466881d Zhi Wang 2016-03-28 1150
b901b252b6cf5c Changbin Du 2018-05-15 1151 /**
a752b070a67823 Zhenyu Wang 2018-07-31 @1152 * Check if can do 2M page
a752b070a67823 Zhenyu Wang 2018-07-31 1153 * @vgpu: target vgpu
a752b070a67823 Zhenyu Wang 2018-07-31 1154 * @entry: target pfn's gtt entry
a752b070a67823 Zhenyu Wang 2018-07-31 1155 *
9317f356df83a5 Bhaskar Chowdhury 2021-02-22 1156 * Return 1 if 2MB huge gtt shadowing is possible, 0 if miscondition,
9317f356df83a5 Bhaskar Chowdhury 2021-02-22 1157 * negative if found err.
b901b252b6cf5c Changbin Du 2018-05-15 1158 */
b901b252b6cf5c Changbin Du 2018-05-15 1159 static int is_2MB_gtt_possible(struct intel_vgpu *vgpu,
b901b252b6cf5c Changbin Du 2018-05-15 1160 struct intel_gvt_gtt_entry *entry)
b901b252b6cf5c Changbin Du 2018-05-15 1161 {
b901b252b6cf5c Changbin Du 2018-05-15 1162 struct intel_gvt_gtt_pte_ops *ops = vgpu->gvt->gtt.pte_ops;
b901b252b6cf5c Changbin Du 2018-05-15 1163 unsigned long pfn;
b901b252b6cf5c Changbin Du 2018-05-15 1164
a61ac1e75105a0 Chris Wilson 2020-03-06 1165 if (!HAS_PAGE_SIZES(vgpu->gvt->gt->i915, I915_GTT_PAGE_SIZE_2M))
b901b252b6cf5c Changbin Du 2018-05-15 1166 return 0;
b901b252b6cf5c Changbin Du 2018-05-15 1167
b901b252b6cf5c Changbin Du 2018-05-15 1168 pfn = intel_gvt_hypervisor_gfn_to_mfn(vgpu, ops->get_pfn(entry));
b901b252b6cf5c Changbin Du 2018-05-15 1169 if (pfn == INTEL_GVT_INVALID_ADDR)
b901b252b6cf5c Changbin Du 2018-05-15 1170 return -EINVAL;
b901b252b6cf5c Changbin Du 2018-05-15 1171
b901b252b6cf5c Changbin Du 2018-05-15 1172 return PageTransHuge(pfn_to_page(pfn));
b901b252b6cf5c Changbin Du 2018-05-15 1173 }
b901b252b6cf5c Changbin Du 2018-05-15 1174

:::::: The code at line 1152 was first introduced by commit
:::::: a752b070a67823174565322cc48b2668daf9a8da drm/i915/gvt: Fix function comment doc errors

:::::: TO: Zhenyu Wang <zhenyuw@linux.intel.com>
:::::: CC: Zhenyu Wang <zhenyuw@linux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2022-01-10 13:24    [W:0.024 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site