lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 00/35] brcmfmac: Support Apple T2 and M1 platforms
    From
    On 2022/01/10 19:14, Kalle Valo wrote:
    > Hector Martin <marcan@marcan.st> writes:
    >
    >> Hi everyone,
    >>
    >> Happy new year! This 35-patch series adds proper support for the
    >> Broadcom FullMAC chips used on Apple T2 and M1 platforms:
    >>
    >> - BCM4355C1
    >> - BCM4364B2/B3
    >> - BCM4377B3
    >> - BCM4378B1
    >> - BCM4387C2
    >
    > 35 patches is a lot to review. It would make things easier for reviewers
    > if you can split this into smaller patchsets, 10-12 patches per set is
    > what I usually recommend. More info in the wiki link below.

    The patches are already split into logical groupings, so I think there
    isn't much more to be gained by sending them separately. As I described
    in the cover letter:

    01~09: Firmware selection stuff
    10~14: Add support for BCM4378
    15~20: Add BCM4355/4364/4377 on top
    21~27: Add BCM4387 and its newer requirements
    28~32: Misc fixes
    33~35: TxCap & calibration support

    If you want to review the series piecemeal, feel free to stop at any of
    those boundaries; the series will still make sense and is useful at any
    of those stopping points.

    Note that the firmware selection stuff (in particular patches #4 and #6)
    will change quite a bit in v3 from the review feedback so far, so you
    might want to skip reviewing those in detail for v2.

    --
    Hector Martin (marcan@marcan.st)
    Public Key: https://mrcn.st/pub

    \
     
     \ /
      Last update: 2022-01-10 12:21    [W:5.627 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site