lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 18/35] brcmfmac: pcie: Add IDs/properties for BCM4355
    On 1/4/2022 8:26 AM, Hector Martin wrote:
    > This chip is present on at least these Apple T2 Macs:
    >
    > * hawaii: MacBook Air 13" (Late 2018)
    > * hawaii: MacBook Air 13" (True Tone, 2019)

    Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
    > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    > Signed-off-by: Hector Martin <marcan@marcan.st>
    > ---
    > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 1 +
    > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 8 ++++++++
    > .../net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++
    > 3 files changed, 11 insertions(+)

    [...]

    > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
    > index a8cccfbea20b..fdba2b5b46f0 100644
    > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
    > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
    > @@ -49,6 +49,7 @@ enum brcmf_pcie_state {
    > BRCMF_FW_DEF(43602, "brcmfmac43602-pcie");
    > BRCMF_FW_DEF(4350, "brcmfmac4350-pcie");
    > BRCMF_FW_DEF(4350C, "brcmfmac4350c2-pcie");
    > +BRCMF_FW_CLM_DEF(4355C1, "brcmfmac4355c1-pcie");
    > BRCMF_FW_CLM_DEF(4356, "brcmfmac4356-pcie");
    > BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie");
    > BRCMF_FW_DEF(4358, "brcmfmac4358-pcie");
    > @@ -75,6 +76,7 @@ static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = {
    > BRCMF_FW_ENTRY(BRCM_CC_4350_CHIP_ID, 0x000000FF, 4350C),
    > BRCMF_FW_ENTRY(BRCM_CC_4350_CHIP_ID, 0xFFFFFF00, 4350),
    > BRCMF_FW_ENTRY(BRCM_CC_43525_CHIP_ID, 0xFFFFFFF0, 4365C),
    > + BRCMF_FW_ENTRY(BRCM_CC_4355_CHIP_ID, 0xFFFFFFFF, 4355C1), /* 12 */

    still intrigued what that trailing number means ;-)

    > BRCMF_FW_ENTRY(BRCM_CC_4356_CHIP_ID, 0xFFFFFFFF, 4356),
    > BRCMF_FW_ENTRY(BRCM_CC_43567_CHIP_ID, 0xFFFFFFFF, 43570),
    > BRCMF_FW_ENTRY(BRCM_CC_43569_CHIP_ID, 0xFFFFFFFF, 43570),
    [unhandled content-type:application/pkcs7-signature]
    \
     
     \ /
      Last update: 2022-01-10 10:13    [W:5.717 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site