Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 10 Jan 2022 10:00:15 +0100 | Subject | Re: [PATCH 2/3] dt-bindings: Add dma-channels for pdma device node |
| |
Hi Zong,
On Wed, Jan 5, 2022 at 6:44 AM Zong Li <zong.li@sifive.com> wrote: > Add dma-channels property, then we can determine how many channels there > by device tree, rather than statically defines it in PDMA driver > > Signed-off-by: Zong Li <zong.li@sifive.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > @@ -34,12 +34,17 @@ properties: > minItems: 1 > maxItems: 8 > > + dma-channels: > + minimum: 1 > + maximum: 4
As per my comment on [PATCH 3/3], perhaps you want to use a default value of 4, and document that here, too?
> + > '#dma-cells': > const: 1 > > required: > - compatible > - reg > + - dma-channels > - interrupts > - '#dma-cells' >
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |