lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 63/72] drm/amdgpu: put SMU into proper state on runpm suspending for BOCO capable platform
    Date
    From: Evan Quan <evan.quan@amd.com>

    [ Upstream commit 7be3be2b027c12e84833b3dc9597d3bb7e4c5464 ]

    By setting mp1_state as PP_MP1_STATE_UNLOAD, MP1 will do some proper cleanups and
    put itself into a state ready for PNP. That can workaround some random resuming
    failure observed on BOCO capable platforms.

    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Guchun Chen <guchun.chen@amd.com>
    Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++
    1 file changed, 15 insertions(+)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    index 9dfd9d70812cb..41677f99c67b1 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    @@ -1606,12 +1606,27 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)
    if (amdgpu_device_supports_px(drm_dev))
    drm_dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;

    + /*
    + * By setting mp1_state as PP_MP1_STATE_UNLOAD, MP1 will do some
    + * proper cleanups and put itself into a state ready for PNP. That
    + * can address some random resuming failure observed on BOCO capable
    + * platforms.
    + * TODO: this may be also needed for PX capable platform.
    + */
    + if (amdgpu_device_supports_boco(drm_dev))
    + adev->mp1_state = PP_MP1_STATE_UNLOAD;
    +
    ret = amdgpu_device_suspend(drm_dev, false);
    if (ret) {
    adev->in_runpm = false;
    + if (amdgpu_device_supports_boco(drm_dev))
    + adev->mp1_state = PP_MP1_STATE_NONE;
    return ret;
    }

    + if (amdgpu_device_supports_boco(drm_dev))
    + adev->mp1_state = PP_MP1_STATE_NONE;
    +
    if (amdgpu_device_supports_px(drm_dev)) {
    /* Only need to handle PCI state in the driver for ATPX
    * PCI core handles it for _PR3.
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-10 09:09    [W:4.037 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site