Messages in this thread Patch in this message | | | From | Miaoqian Lin <> | Subject | [PATCH] coresight: syscfg: Fix memleak on registration failure in cscfg_create_device | Date | Mon, 10 Jan 2022 07:31:00 +0000 |
| |
device_register() calls device_initialize(), according to doc of device_initialize:
Use put_device() to give up your reference instead of freeing * @dev directly once you have called this function.
To prevent potential memleak, use put_device() instead call kfree directly.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/hwtracing/coresight/coresight-syscfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c index 43054568430f..007fa1c761a7 100644 --- a/drivers/hwtracing/coresight/coresight-syscfg.c +++ b/drivers/hwtracing/coresight/coresight-syscfg.c @@ -764,7 +764,7 @@ struct device *cscfg_device(void) /* Must have a release function or the kernel will complain on module unload */ static void cscfg_dev_release(struct device *dev) { - kfree(cscfg_mgr); + put_device(dev); cscfg_mgr = NULL; } -- 2.17.1
| |