lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050 clock driver
On 22-01-10 12:12:00, Stephen Boyd wrote:
> Quoting Jesse Taube (2022-01-09 11:07:42)
> > >> +
> > >> + clk_hw_data->num = IMXRT1050_CLK_END;
> > >> + hws = clk_hw_data->hws;
> > >> +
> > >> + hws[IMXRT1050_CLK_OSC] = __clk_get_hw(of_clk_get_by_name(np, "osc"));
> > >
> > > Use clk_parent_data instead and reference the binding name with .fw_name
> >
> > Hi Stephen, sorry to bother you again.
> > I'm wondering if adding `clk_parent_data` is necessary as it seems like
> > it wold be a big change and the other IMX boards haven't implemented
> > this yet would it be okay if I don't do this, or if it is necessary
> > could you link to a patch set to change it.
> >
>
> Is it a big change because the imx_clk_hw*() APIs aren't prepared for
> non-string parents? Can you make some clk_parent_data based APIs and
> migrate things over gradually? This is really a question for i.MX folks
> to see if anyone is working on moving away from the string names.

I'm currently looking into it. I would suggest we take this patch as is
and I'll switch it later on to clk_parent_data.

\
 
 \ /
  Last update: 2022-01-10 23:49    [W:0.524 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site