Messages in this thread | | | Subject | Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu. | From | John Garry <> | Date | Mon, 10 Jan 2022 17:51:33 +0000 |
| |
On 10/01/2022 17:36, Ian Rogers wrote: > I think you are asking to squash: > https://lore.kernel.org/lkml/20220105061351.120843-8-irogers@google.com/ > into this change.
That's the general idea.
> There are other similar related changes that may > also be squashed. The changes are trying to introduce a new API and > then add changes to switch over to using it. This is with a view to > making bisection easier, have each change only do 1 thing and so on. I > believe the format of the patches is house style, but it is fine to > squash changes together too. Having sent patches to Arnaldo and having > had them split I'm reluctant to do a v5 with them squashed without him > expressing a preference. >
I don't feel so strongly. But I do think that ability to review should take preference to providing simple bisections.
Anyway, I'll stop talking and actually have a look.
Cheers, John
| |