Messages in this thread | | | Date | Mon, 10 Jan 2022 18:48:39 +0100 | Subject | Re: [PATCH 1/5] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively | From | Cezary Rojewski <> |
| |
On 2022-01-10 5:03 PM, Lad, Prabhakar wrote: > Hi Cezary, > > Thank you for the review. >
...
>> Recursion and loops are means for doing something repeatedly. Could you >> specify _why_ such change was made i.e. the conversion from one method >> into the other? I bet the code is not being changed for the sake of >> changing it, the reason is simply missing in the commit message. >> > I had feedback from Pavel "recursion is unwelcome in kernel due to > limited stack use." which I did agree with as a result I have come up > with this patch. Also to add this driver will later be used on Renesas > RZ/A2 SoC's which runs with limited memory.
Adding that reasoning to the commits message will prevent questions (such as mine) in the future. Thank you for a quick reply and a transparent answer.
Regards, Czarek
| |