lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu.
    From
    Date
    On 05/01/2022 06:13, Ian Rogers wrote:
    >
    > +struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx,
    > + void *data)
    > +{
    > + if (idx < 0 || idx > map->nr)
    > + return cpu_map__empty_aggr_cpu_id();
    > +
    > + return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data);
    > +}
    > +


    This is later deleted in the series. Can the series be reworked so that
    we don't add stuff and then later delete it? One reason for that
    approach is that we don't spend time reviewing something which will be
    deleted, especially in such a big series...

    If it really makes sense to do it this way then fine.

    Thanks,
    John

    \
     
     \ /
      Last update: 2022-01-10 18:11    [W:4.202 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site