Messages in this thread | | | Date | Mon, 10 Jan 2022 10:37:32 +0530 | From | Pratyush Yadav <> | Subject | Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm |
| |
Hi Dhananjay,
On 08/01/22 08:44PM, Dhananjay Phadke wrote: > Add support for Winbond 64MB W25Q512JV-DTR NOR flash. > Use PARSE_SFDP flag to init parameters during SFDP parsing. > > Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com> > ---
You need to show the dumps of the SFDP and other flash parameters. See [0] for an example.
The patch looks fine to me otherwise.
[0] https://patchwork.ozlabs.org/project/linux-mtd/patch/20211209190436.401946-2-tudor.ambarus@microchip.com/
> drivers/mtd/spi-nor/winbond.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c > index 675f32c136b3..ebc826e21f76 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -118,6 +118,8 @@ static const struct flash_info winbond_parts[] = { > .fixups = &w25q256_fixups }, > { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512) > PARSE_SFDP }, > + { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024), > + PARSE_SFDP }, > { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512) > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | > SPI_NOR_QUAD_READ) }, > -- > 2.25.1 >
-- Regards, Pratyush Yadav Texas Instruments Inc.
| |