lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.13 212/219] selftests/bpf: Fix potential unreleased lock
    Date
    From: Chengfeng Ye <cyeaa@connect.ust.hk>

    [ Upstream commit 47bb27a20d6ea22cd092c1fc2bb4fcecac374838 ]

    This lock is not released if the program
    return at the patched branch.

    Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Link: https://lore.kernel.org/bpf/20210827074140.118671-1-cyeaa@connect.ust.hk
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
    index ec281b0363b8..86f97681ad89 100644
    --- a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
    +++ b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
    @@ -195,8 +195,10 @@ static void run_test(int cgroup_fd)

    pthread_mutex_lock(&server_started_mtx);
    if (CHECK_FAIL(pthread_create(&tid, NULL, server_thread,
    - (void *)&server_fd)))
    + (void *)&server_fd))) {
    + pthread_mutex_unlock(&server_started_mtx);
    goto close_server_fd;
    + }
    pthread_cond_wait(&server_started, &server_started_mtx);
    pthread_mutex_unlock(&server_started_mtx);

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 14:37    [W:2.395 / U:0.556 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site