lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.13 145/219] iomap: pass writeback errors to the mapping
    Date
    From: "Darrick J. Wong" <djwong@kernel.org>

    [ Upstream commit b69eea82d37d9ee7cfb3bf05103549dd4ed5ffc3 ]

    Modern-day mapping_set_error has the ability to squash the usual
    negative error code into something appropriate for long-term storage in
    a struct address_space -- ENOSPC becomes AS_ENOSPC, and everything else
    becomes EIO. iomap squashes /everything/ to EIO, just as XFS did before
    that, but this doesn't make sense.

    Fix this by making it so that we can pass ENOSPC to userspace when
    writeback fails due to space problems.

    Signed-off-by: Darrick J. Wong <djwong@kernel.org>
    Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/iomap/buffered-io.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
    index 9023717c5188..35839acd0004 100644
    --- a/fs/iomap/buffered-io.c
    +++ b/fs/iomap/buffered-io.c
    @@ -1045,7 +1045,7 @@ iomap_finish_page_writeback(struct inode *inode, struct page *page,

    if (error) {
    SetPageError(page);
    - mapping_set_error(inode->i_mapping, -EIO);
    + mapping_set_error(inode->i_mapping, error);
    }

    WARN_ON_ONCE(i_blocks_per_page(inode, page) > 1 && !iop);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 14:37    [W:4.073 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site