lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH] of: property: Disable fw_devlink DT support for X86
    From
    Andre reported fw_devlink=on breaking OLPC XO-1.5 [1].

    OLPC XO-1.5 is an X86 system that uses a mix of ACPI and OF to populate
    devices. The root cause seems to be ISA devices not setting their fwnode
    field. But trying to figure out how to fix that doesn't seem worth the
    trouble because the OLPC devicetree is very sparse/limited and fw_devlink
    only adds the links causing this issue. Considering that there aren't many
    users of OF in an X86 system, simply fw_devlink DT support for X86.

    [1] - https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0@web.de/
    Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""")
    Signed-off-by: Saravana Kannan <saravanak@google.com>
    Cc: Andre Muller <andre.muller@web.de>
    ---
    drivers/of/property.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/of/property.c b/drivers/of/property.c
    index 0c0dc2e369c0..3fd74bb34819 100644
    --- a/drivers/of/property.c
    +++ b/drivers/of/property.c
    @@ -1444,6 +1444,9 @@ static int of_fwnode_add_links(struct fwnode_handle *fwnode)
    struct property *p;
    struct device_node *con_np = to_of_node(fwnode);

    + if (IS_ENABLED(CONFIG_X86))
    + return 0;
    +
    if (!con_np)
    return -EINVAL;

    --
    2.33.0.309.g3052b89438-goog
    \
     
     \ /
      Last update: 2021-09-10 03:23    [W:3.269 / U:1.640 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site