lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 15/17] checkkconfigsymbols.py: Fix the '--ignore' option
    Date
    From: Ariel Marcovitch <arielmarcovitch@gmail.com>

    [ Upstream commit 1439ebd2ce77242400518d4e6a1e85bebcd8084f ]

    It seems like the implementation of the --ignore option is broken.

    In check_symbols_helper, when going through the list of files, a file is
    added to the list of source files to check if it matches the ignore
    pattern. Instead, as stated in the comment below this condition, the
    file should be added if it doesn't match the pattern.

    This means that when providing an ignore pattern, the only files that
    will be checked will be the ones we want the ignore, in addition to the
    Kconfig files that don't match the pattern (the check in
    parse_kconfig_files is done right)

    Signed-off-by: Ariel Marcovitch <arielmarcovitch@gmail.com>
    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    scripts/checkkconfigsymbols.py | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
    index a32e4da4c117..d96ea8ded18a 100755
    --- a/scripts/checkkconfigsymbols.py
    +++ b/scripts/checkkconfigsymbols.py
    @@ -329,7 +329,7 @@ def check_symbols_helper(pool, ignore):
    if REGEX_FILE_KCONFIG.match(gitfile):
    kconfig_files.append(gitfile)
    else:
    - if ignore and not re.match(ignore, gitfile):
    + if ignore and re.match(ignore, gitfile):
    continue
    # add source files that do not match the ignore pattern
    source_files.append(gitfile)
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-10 03:07    [W:2.547 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site