lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] perf list: Display hybrid pmu events with cpu type
From
Date


On 9/10/2021 6:56 AM, Andi Kleen wrote:
>
> On 9/9/2021 3:37 PM, Ian Rogers wrote:
>> On Thu, Sep 2, 2021 at 7:54 PM Jin Yao <yao.jin@linux.intel.com> wrote:
>>> Add a new option '--cputype' to perf-list to display core-only pmu events
>>> or atom-only pmu events.
>>>
>>> Each hybrid pmu event has been assigned with a pmu name, this patch
>>> compares the pmu name before listing the result.
>> Would this work more broadly for any PMU type? If so perhaps pmu
>> rather than cputype is a more appropriate option name?
>
> It's not just the cpu pmu, because it still lists the uncore events, which makes sense.
>
> If you want to match the pmu it probably would make sense to match it in the default matching for
> non option arguments in perf list. But that would be a different patch.
>
> -Andi
>
>

Yes, agree with Andi. Besides for cpu pmu events, it also lists the software events and uncore
events. So probably cputype is an appropriate option name.

Thanks
Jin Yao

\
 
 \ /
  Last update: 2021-09-10 03:07    [W:1.567 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site