lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 45/99] scsi: qla2xxx: Fix NPIV create erroneous error
    Date
    From: Quinn Tran <qutran@marvell.com>

    [ Upstream commit a57214443f0f85639a0d9bbb8bd658d82dbf0927 ]

    When user creates multiple NPIVs, the switch capabilities field is checked
    before a vport is allowed to be created. This field is being toggled if a
    switch scan is in progress. This creates erroneous reject of vport create.

    Link: https://lore.kernel.org/r/20210810043720.1137-10-njavali@marvell.com
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Quinn Tran <qutran@marvell.com>
    Signed-off-by: Nilesh Javali <njavali@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_init.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
    index f40e233c8ce5..27d10524ec3e 100644
    --- a/drivers/scsi/qla2xxx/qla_init.c
    +++ b/drivers/scsi/qla2xxx/qla_init.c
    @@ -4531,11 +4531,11 @@ qla2x00_configure_hba(scsi_qla_host_t *vha)
    /* initialize */
    ha->min_external_loopid = SNS_FIRST_LOOP_ID;
    ha->operating_mode = LOOP;
    - ha->switch_cap = 0;

    switch (topo) {
    case 0:
    ql_dbg(ql_dbg_disc, vha, 0x200b, "HBA in NL topology.\n");
    + ha->switch_cap = 0;
    ha->current_topology = ISP_CFG_NL;
    strcpy(connect_type, "(Loop)");
    break;
    @@ -4549,6 +4549,7 @@ qla2x00_configure_hba(scsi_qla_host_t *vha)

    case 2:
    ql_dbg(ql_dbg_disc, vha, 0x200d, "HBA in N P2P topology.\n");
    + ha->switch_cap = 0;
    ha->operating_mode = P2P;
    ha->current_topology = ISP_CFG_N;
    strcpy(connect_type, "(N_Port-to-N_Port)");
    @@ -4565,6 +4566,7 @@ qla2x00_configure_hba(scsi_qla_host_t *vha)
    default:
    ql_dbg(ql_dbg_disc, vha, 0x200f,
    "HBA in unknown topology %x, using NL.\n", topo);
    + ha->switch_cap = 0;
    ha->current_topology = ISP_CFG_NL;
    strcpy(connect_type, "(Loop)");
    break;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-10 02:43    [W:6.260 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site