lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 40/74] media: tegra-cec: Handle errors of clk_prepare_enable()
    Date
    From: Evgeny Novikov <novikov@ispras.ru>

    [ Upstream commit 38367073c796a37a61549b1f66a71b3adb03802d ]

    tegra_cec_probe() and tegra_cec_resume() ignored possible errors of
    clk_prepare_enable(). The patch fixes this.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/tegra-cec/tegra_cec.c | 10 ++++++----
    1 file changed, 6 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/platform/tegra-cec/tegra_cec.c b/drivers/media/platform/tegra-cec/tegra_cec.c
    index aba488cd0e64..a2c20ca799c4 100644
    --- a/drivers/media/platform/tegra-cec/tegra_cec.c
    +++ b/drivers/media/platform/tegra-cec/tegra_cec.c
    @@ -383,7 +383,11 @@ static int tegra_cec_probe(struct platform_device *pdev)
    return -ENOENT;
    }

    - clk_prepare_enable(cec->clk);
    + ret = clk_prepare_enable(cec->clk);
    + if (ret) {
    + dev_err(&pdev->dev, "Unable to prepare clock for CEC\n");
    + return ret;
    + }

    /* set context info. */
    cec->dev = &pdev->dev;
    @@ -462,9 +466,7 @@ static int tegra_cec_resume(struct platform_device *pdev)

    dev_notice(&pdev->dev, "Resuming\n");

    - clk_prepare_enable(cec->clk);
    -
    - return 0;
    + return clk_prepare_enable(cec->clk);
    }
    #endif

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 15:40    [W:4.068 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site