lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 149/176] selftests/bpf: Enlarge select() timeout for test_maps
    Date
    From: Li Zhijian <lizhijian@cn.fujitsu.com>

    [ Upstream commit 2d82d73da35b72b53fe0d96350a2b8d929d07e42 ]

    0Day robot observed that it's easily timeout on a heavy load host.
    -------------------
    # selftests: bpf: test_maps
    # Fork 1024 tasks to 'test_update_delete'
    # Fork 1024 tasks to 'test_update_delete'
    # Fork 100 tasks to 'test_hashmap'
    # Fork 100 tasks to 'test_hashmap_percpu'
    # Fork 100 tasks to 'test_hashmap_sizes'
    # Fork 100 tasks to 'test_hashmap_walk'
    # Fork 100 tasks to 'test_arraymap'
    # Fork 100 tasks to 'test_arraymap_percpu'
    # Failed sockmap unexpected timeout
    not ok 3 selftests: bpf: test_maps # exit=1
    # selftests: bpf: test_lru_map
    # nr_cpus:8
    -------------------
    Since this test will be scheduled by 0Day to a random host that could have
    only a few cpus(2-8), enlarge the timeout to avoid a false NG report.

    In practice, i tried to pin it to only one cpu by 'taskset 0x01 ./test_maps',
    and knew 10S is likely enough, but i still perfer to a larger value 30.

    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Acked-by: Song Liu <songliubraving@fb.com>
    Link: https://lore.kernel.org/bpf/20210820015556.23276-2-lizhijian@cn.fujitsu.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/test_maps.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
    index 0d92ebcb335d..179e680e8d13 100644
    --- a/tools/testing/selftests/bpf/test_maps.c
    +++ b/tools/testing/selftests/bpf/test_maps.c
    @@ -968,7 +968,7 @@ static void test_sockmap(unsigned int tasks, void *data)

    FD_ZERO(&w);
    FD_SET(sfd[3], &w);
    - to.tv_sec = 1;
    + to.tv_sec = 30;
    to.tv_usec = 0;
    s = select(sfd[3] + 1, &w, NULL, NULL, &to);
    if (s == -1) {
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 15:07    [W:5.357 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site