Messages in this thread | | | Date | Wed, 8 Sep 2021 08:29:56 -0700 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support |
| |
On Wed, Sep 08, 2021 at 02:37:39PM +0530, skakit@codeaurora.org wrote: > On 2021-09-07 23:46, Matthias Kaehlcke wrote: > > On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote: > > > Add pwm support for PM8350C pmic. > > > > > > Signed-off-by: satya priya <skakit@codeaurora.org> > > > --- > > > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > index e1b75ae..ecdae55 100644 > > > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > @@ -29,6 +29,12 @@ > > > interrupt-controller; > > > #interrupt-cells = <2>; > > > }; > > > + > > > + pm8350c_pwm4: pwm { > > > > What does the '4' represent, an internal channel number? It should > > probably be omitted if the PM8350 only has a single output PWM > > port. > > > > pm8350c has four PWMs, but I think we can drop the '4' here.
Why is only one PWM exposed if the PMIC has for of them? Why number 4 and not one of the others?
| |