Messages in this thread | | | From | "Jason A. Donenfeld" <> | Date | Wed, 8 Sep 2021 13:27:12 +0200 | Subject | Re: [PATCH] wireguard: convert index_hashtable and pubkey_hashtable into rhashtables |
| |
Hi Hamza,
Thanks for this patch. I have a few concerns/questions about it:
- What's performance like? Does the abstraction of rhashtable introduce overhead? These are used in fast paths -- for every packet -- so being quick is important.
- How does this interact with the timing side channel concerns in the comment of the file? Will the time required to find an unused index leak the number of items in the hash table? Do we need stochastic masking? Or is the construction of rhashtable such that we always get ball-park same time?
Thanks, Jason
| |