Messages in this thread | | | Subject | Re: [PATCH 1/2] soc: amlogic: canvas: Make use of the helper function devm_platform_ioremap_resource() | From | Neil Armstrong <> | Date | Wed, 8 Sep 2021 09:47:50 +0200 |
| |
On 08/09/2021 09:15, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/soc/amlogic/meson-canvas.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c > index d0329ad170d1..383b0cfc584e 100644 > --- a/drivers/soc/amlogic/meson-canvas.c > +++ b/drivers/soc/amlogic/meson-canvas.c > @@ -168,7 +168,6 @@ EXPORT_SYMBOL_GPL(meson_canvas_free); > > static int meson_canvas_probe(struct platform_device *pdev) > { > - struct resource *res; > struct meson_canvas *canvas; > struct device *dev = &pdev->dev; > > @@ -176,8 +175,7 @@ static int meson_canvas_probe(struct platform_device *pdev) > if (!canvas) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - canvas->reg_base = devm_ioremap_resource(dev, res); > + canvas->reg_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(canvas->reg_base)) > return PTR_ERR(canvas->reg_base); > >
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
| |