lkml.org 
[lkml]   [2021]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
From
Date
On 9/7/21 7:07 AM, Jarkko Sakkinen wrote:
>> If I just #include <asm/sgx.h> in those files I'll break the build for other
>> architectures.
> What does specifically break the build?

Remember, our x86 "<asm/sgx.h>" is:

arch/x86/include/asm/sgx.h

On powerpc, "<asm/sgx.h>" is:

arch/powerpc/include/asm/sgx.h

You'll get a file not found error looking for sgx.h.

That said... Tony, it's probably a bit more friendly if the mm.h code
you add:

> +#ifdef CONFIG_X86_SGX
> +int sgx_memory_failure(unsigned long pfn, int flags);
> +bool sgx_is_epc_page(u64 paddr);
> +#else
> +static inline int sgx_memory_failure(unsigned long pfn, int flags)
> +{
> + return -ENXIO;
> +}
> +
> +static inline bool sgx_is_epc_page(u64 paddr)
> +{
> + return false;
> +}
> +#endif

was a bit more generic. Maybe something like:

int arch_memory_failure(unsigned long pfn, int flags);

BTW, I don't see sgx_is_epc_page() in arch-generic code. Does it really
need to be in mm.h?

\
 
 \ /
  Last update: 2021-09-07 16:14    [W:0.385 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site