Messages in this thread | | | Date | Sat, 4 Sep 2021 21:06:30 +0200 | Subject | Re: [PATCH 0/6] staging: r8188eu: remove some functions from hal_ops | From | Michael Straube <> |
| |
On 9/4/21 20:27, Phillip Potter wrote: > On Sat, 4 Sept 2021 at 13:40, Michael Straube <straube.linux@gmail.com> wrote: >> >> Getting rid of the hal layer is on the todo list. This series >> removes some functions from hal_ops and make the driver call the >> pointed functions directly. >> >> Tested with Inter-Tech DMG-02. >> >> Michael Straube (6): >> staging: r8188eu: remove intf_chip_configure from hal_ops >> staging: r8188eu: remove read_adapter_info from hal_ops >> staging: r8188eu: remove read_chip_version from hal_ops >> staging: r8188eu: remove wrapper around ReadChipVersion8188E() >> staging: r8188eu: remove GetHalODMVarHandler from hal_ops >> staging: r8188eu: remove init_default_value from hal_ops >> >> drivers/staging/r8188eu/hal/hal_intf.c | 33 ------------------- >> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 16 +-------- >> drivers/staging/r8188eu/hal/usb_halinit.c | 10 ++---- >> drivers/staging/r8188eu/include/hal_intf.h | 22 +++---------- >> .../staging/r8188eu/include/rtl8188e_hal.h | 2 ++ >> drivers/staging/r8188eu/os_dep/os_intfs.c | 4 +-- >> drivers/staging/r8188eu/os_dep/usb_intf.c | 7 ++-- >> 7 files changed, 16 insertions(+), 78 deletions(-) >> >> -- >> 2.33.0 >> > > Dear Michael, > > Looks good to me, built and tested here: > Acked-by: Phillip Potter <phil@philpotter.co.uk> > > Regards, > Phil >
Thanks for your review and testing Phillip. Much appreciated.
Regards, Michael
| |