Messages in this thread | | | Subject | Re: [PATCH] staging: r8188eu: os_dep: simplifiy the rtw_resume function | From | Saurav Girepunje <> | Date | Sat, 4 Sep 2021 17:34:29 +0530 |
| |
On 04/09/21 3:36 pm, Greg KH wrote: > On Sat, Sep 04, 2021 at 03:09:13PM +0530, Saurav Girepunje wrote: >> Remove unused variable ret and pwrpriv. >> Remove the condition with no effect (if == else) in usb_intf.c >> file. >> >> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> >> --- >> drivers/staging/r8188eu/os_dep/usb_intf.c | 8 +------- >> 1 file changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c >> index bb85ab77fd26..673cd3001183 100644 >> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c >> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c >> @@ -493,14 +493,8 @@ static int rtw_resume(struct usb_interface *pusb_intf) >> { >> struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf); >> struct adapter *padapter = dvobj->if1; >> - struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv; >> - int ret = 0; >> >> - if (pwrpriv->bInternalAutoSuspend) >> - ret = rtw_resume_process(padapter); >> - else >> - ret = rtw_resume_process(padapter); >> - return ret; >> + return rtw_resume_process(padapter); >> } >> >> int rtw_resume_process(struct adapter *padapter) > > Why not just delete the rtw_resume_process() declaration line and make > the rtw_resume() function be the whole thing, as rtw_resume_process() is > never called anywhere else. That would be even more lines of code > removed and simplified here. > > thanks, > > greg k-h >
Yes, rtw_resume_process function can be removed . Thanks for review greg.
Regards, Saurav Girepunje
| |